Feedforward

[amolenaar]

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

[sourcery-ai]

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.80%.

Quality metrics	Before	After	Change
Complexity	3.92 ⭐	3.58 ⭐	-0.34 👍
Method Length	52.51 ⭐	53.25 ⭐	0.74 👎
Working memory	5.96 ⭐	5.97 ⭐	0.01 👎
Quality	73.25% 🙂	74.05% 🙂	0.80% 👍

Other metrics	Before	After	Change
Lines	1111	1108	-3

Changed files	Quality Before	Quality After	Quality Change
gaphas/guide.py	80.37% ⭐	80.37% ⭐	0.00%
gaphas/handlemove.py	76.72% ⭐	76.33% ⭐	-0.39% 👎
gaphas/segment.py	60.59% 🙂	62.01% 🙂	1.42% 👍
gaphas/aspect/handlemove.py	%	%	%
gaphas/painter/handlepainter.py	54.90% 🙂	66.74% 🙂	11.84% 👍
gaphas/tool/hover.py	89.27% ⭐	78.69% ⭐	-10.58% 👎
gaphas/view/__init__.py	%	%	%
gaphas/view/gtkview.py	76.42% ⭐	76.55% ⭐	0.13% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
gaphas/view/gtkview.py	GtkView.update_back_buffer	15 🙂	235 ⛔	10 😞	42.03% 😞	Try splitting into smaller methods. Extract out complex expressions
gaphas/segment.py	LineSegment.merge_segment	9 🙂	190 😞	10 😞	50.40% 🙂	Try splitting into smaller methods. Extract out complex expressions
gaphas/segment.py	LineSegment.split_segment	6 ⭐	237 ⛔		50.46% 🙂	Try splitting into smaller methods
gaphas/view/gtkview.py	GtkView.__init__	6 ⭐	226 ⛔		51.44% 🙂	Try splitting into smaller methods
gaphas/painter/handlepainter.py	HandlePainter._draw_handles	11 🙂	128 😞	9 🙂	56.84% 🙂	Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!