Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the rubberband selection look a little nicer #61

Merged
merged 1 commit into from Jun 11, 2019

Conversation

amolenaar
Copy link
Member

A nice dashed line with a almost transparent fill.

Screenshot 2019-06-08 at 23 08 36

@danyeaw
Copy link
Member

danyeaw commented Jun 9, 2019

Screenshot from 2019-06-08 21-17-13
How do make use of this in the demo?

@amolenaar
Copy link
Member Author

The demo should use it. You’re stuck on older code I think.

@amolenaar amolenaar merged commit 3d5b1df into master Jun 11, 2019
@danyeaw danyeaw deleted the nicer-rubberband-tool branch June 12, 2019 00:16
@danyeaw
Copy link
Member

danyeaw commented Jun 12, 2019

@amolenaar ya, I am still not sure what the workflow is without a setup.py. Trying to use editable mode doesn't seem to work anymore:

$ pip install -e .
ERROR: File "setup.py" not found. Directory cannot be installed in editable mode: /home/dan/Projects/gaphas
(A "pyproject.toml" file was found, but editable mode currently requires a setup.py based build.)

I do like the new look, thanks for updating this 👍

@amolenaar
Copy link
Member Author

I installed with poetry, and that works just fine. It looks like the pip folks still have some work to do, given the comment. Is installing in developer/edit mode not part of the PEP?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants