Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected error after creating a package #1952

Closed
1 of 3 tasks
sz332 opened this issue Dec 25, 2022 · 2 comments · Fixed by #1959
Closed
1 of 3 tasks

Unexpected error after creating a package #1952

sz332 opened this issue Dec 25, 2022 · 2 comments · Fixed by #1959
Labels
bug An issue in the application

Comments

@sz332
Copy link
Contributor

sz332 commented Dec 25, 2022

Describe the bug

Unexpected error when creating a package

To Reproduce

Steps to reproduce the behavior:

  1. Start gaphor
  2. Select sysml
  3. Select each element and press delete to remove all package
  4. Create new package diagram
  5. Select the diagram on left side and press right mouse click
  6. Select new package menu item

OS: Windows (10)
Python version: 3.11.1
GTK version: 4.8.1
Display: GdkWin32Display
Gaphor version: 2.14.0

Errors:

Time since application startup: 0:01:01
|Traceback (most recent call last):
| File "F:\Development\Tools\Gaphor\gaphor-2.14.0-portable\data\gaphor\ui\actiongroup.pyc", line 191, in _action_activate
| File "F:\Development\Tools\Gaphor\gaphor-2.14.0-portable\data\gaphor\ui\treecomponent.pyc", line 159, in tree_view_create_package
|AssertionError
└─────────────────────────────╌┄┈

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

OS

  • Linux (Please put in notes the specific distro)
  • macOS
  • Windows

Version

Version of Gaphor: 2.14.0

Additional information

Add any other context about the problem here.
@amolenaar
Copy link
Member

Indeed, the Add Package option should not be enabled when using the popup on anything but packages.

@danyeaw danyeaw mentioned this issue Dec 26, 2022
Closed
danyeaw added a commit that referenced this issue Dec 26, 2022
@danyeaw
Hide New Package menu unless package selected
0cf7e51 
Fixes #1952. Previously the New Package option was visible always on the
right click menu. This changes the behavior so that you can only next a
package under another package.
danyeaw added a commit that referenced this issue Dec 26, 2022
@danyeaw
Hide New Package menu unless package selected
1d5b346 
Fixes #1952 which was an assertion error while creating a new package.
Previously, the New Package option was always visible on the right click
menu. This changes the behavior so that you can only nest a package
under another package.
@danyeaw danyeaw mentioned this issue Dec 26, 2022
Merged
8 tasks
@danyeaw danyeaw added the bug An issue in the application label Dec 26, 2022
@danyeaw
Copy link
Member

danyeaw commented Dec 26, 2022

Thanks @sz332 for the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug An issue in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide New Package menu unless package selected gaphor/gaphor
3 participants
@amolenaar @sz332 @danyeaw