Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in-diagram editor to something workable #108

Merged
merged 3 commits into from
Mar 24, 2019
Merged

Conversation

amolenaar
Copy link
Member

It should still submit text when clicked outside the editor window.

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Text can only be edited via the Editor window

Issue Number: #94

What is the new behavior?

Double click on a diagram item will open a editor box.

It should still submit text when clicked outside the editor window.
@amolenaar amolenaar requested a review from danyeaw March 24, 2019 16:42
@amolenaar amolenaar changed the title Fix in-diagram editor to somethinng workable Fix in-diagram editor to something workable Mar 24, 2019
@danyeaw
Copy link
Member

danyeaw commented Mar 24, 2019

@amolenaar Thanks for working on this! I am getting a seg fault when I load the editor in Linux. I will see if I can narrow it down to one of the changes you made. Do you know how to run Gaphor through gdb to get GTK debug info? I have never had success every time I try this.

@danyeaw
Copy link
Member

danyeaw commented Mar 24, 2019

@amolenaar Removing the resize mode did fix the initial seg fault. I did find another one, but it is there with the master branch as well, so this is definitely an improvement. 👍

I can submit a separate issue about that one.

@amolenaar amolenaar merged commit 0331e10 into master Mar 24, 2019
@danyeaw danyeaw deleted the in-diagram-editor branch March 24, 2019 20:59
@amolenaar
Copy link
Member Author

@danyeaw I did some old fashioned comment-out-the-line debugging in order to reveal the issue. I'm happy to track down the other segfault as well, if you can point me in the right direction.

@danyeaw
Copy link
Member

danyeaw commented Mar 24, 2019

@amolenaar Nice 😄. It looks like you already found the issue as well with #96.

@amolenaar amolenaar mentioned this pull request Mar 25, 2019
7 tasks
@amolenaar amolenaar restored the in-diagram-editor branch March 30, 2019 21:05
@amolenaar amolenaar deleted the in-diagram-editor branch March 30, 2019 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants