Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix splitting of lines #1326

Merged
merged 1 commit into from Jan 29, 2022
Merged

Fix splitting of lines #1326

merged 1 commit into from Jan 29, 2022

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

It's no possble to split a line in two segments.

Issue Number: #1312

What is the new behavior?

Start a transaction on drag-begin, So handle creation happens within a transaction.

Reverts d555859 (except for one line).

Fixes #1312.

Does this PR introduce a breaking change?

  • Yes
  • No

So handle creation happens within a transaction.

Reverts d555859 (except for one line).

Fixes #1312.
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 27, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.28%.

Quality metrics Before After Change
Complexity 1.22 ⭐ 1.09 ⭐ -0.13 👍
Method Length 22.50 ⭐ 21.50 ⭐ -1.00 👍
Working memory 4.98 ⭐ 4.89 ⭐ -0.09 👍
Quality 88.63% 88.91% 0.28% 👍
Other metrics Before After Change
Lines 70 63 -7
Changed files Quality Before Quality After Quality Change
gaphor/diagram/tools/txtool.py 96.23% ⭐ 97.42% ⭐ 1.19% 👍
gaphor/diagram/tools/tests/test_txtool.py 82.24% ⭐ 82.44% ⭐ 0.20% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@danyeaw danyeaw added the fix A fix for a bug label Jan 27, 2022
@danyeaw danyeaw merged commit 0487c64 into master Jan 29, 2022
@danyeaw danyeaw deleted the fix-create-segment branch January 29, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot add segments to line connectors
2 participants