Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AppImage Crashes on Save Command #1364

Merged
merged 6 commits into from Mar 13, 2022
Merged

Fix AppImage Crashes on Save Command #1364

merged 6 commits into from Mar 13, 2022

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Feb 19, 2022

This PR sets the environmental variable XDG_DATA_DIRS so that Gtk can find the user-specific data files related to GNOME when compiled from source. Also, librsvg was failing to build and this updates the dependencies to fix that issue with the docker image.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

AppImage version of Gaphor crashes on save.

Issue Number: #1355

What is the new behavior?

No crashes

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the fix A fix for a bug label Feb 19, 2022
@danyeaw danyeaw added the not-quite-right This feature is not ready yet label Feb 20, 2022
@danyeaw
Copy link
Member Author

danyeaw commented Feb 20, 2022

I am getting the same error, so this isn't quite right.

@amolenaar
Copy link
Member

Should we set the GSETTINGS_SCHEMA_DIR variable when the Gaphor is started maybe?

@danyeaw
Copy link
Member Author

danyeaw commented Feb 21, 2022

I think the issue is that XDG_DATA_DIRS was not set to where jhbuild's share folder was, and then PyInstaller didn't know where to find the GLib schemas.

@danyeaw danyeaw removed the not-quite-right This feature is not ready yet label Mar 13, 2022
@danyeaw danyeaw requested a review from amolenaar March 13, 2022 14:11
@amolenaar
Copy link
Member

Looks good.

@amolenaar amolenaar merged commit 762cd17 into master Mar 13, 2022
@amolenaar amolenaar deleted the fix/appimage-fixes branch March 13, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants