Package GSettings daemon schemas for AppImage #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
danyeaw
force-pushed
the
fix-appimage-wayland
branch
3 times, most recently
from
9ae1240
to
f200b28
Compare
danyeaw
force-pushed
the
fix-appimage-wayland
branch
from
93d4c20
to
db23291
Compare
|
@amolenaar I think this is good to go now, but I'll give you a chance to review the changes I made as well. Pip was throwing some weird setuptools not found error when not using a virtualenv with the Docker container (even with setuptools installed), so I switched the CI to use pipx instead to keep things isolated when installing poetry. |
danyeaw
approved these changes
Feb 11, 2023
|
Looks good. It's a bit awkward that poetry needs to be installed via pipx, though. |
|
I submitted an enhancement request to pipx since pipx is already installed by default on the GitHub Actions runners, and we shouldn't have to reinstall it for Python 3.11: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The AppImage crashes when run on Wayland
Issue Number: #1920
What is the new behavior?
GSettings daemon schemas are also included. Now our Wayland environment also starts.
Does this PR introduce a breaking change?
Other information
I'm not sure how I can build and upload a new images to ghrc.io. The docker image used to build the AppImage should be updated as well.