Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow nested searches on namespace view #228

Merged
merged 2 commits into from Nov 7, 2019
Merged

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Nov 6, 2019

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Search was only possible on already expanded nodes in the tree view.

What is the new behavior?

When searching, nodes that have matching children will expand, allowing for better searching.

It would probably need some sort of highlighting, to distinguish those nodes even better.

No elements are filtered out of the view.

searching has been completely disabled for tree/list views used in the Element editor.

Does this PR introduce a breaking change?

  • Yes
  • No

@danyeaw danyeaw merged commit c884cae into master Nov 7, 2019
@danyeaw danyeaw deleted the improve-namespace-search branch November 7, 2019 01:21
@danyeaw
Copy link
Member

danyeaw commented Nov 7, 2019

👍

@danyeaw danyeaw added this to the 1.2.0 milestone Nov 7, 2019
@danyeaw danyeaw added the feature A new feature label Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants