Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization/Localization support #236

Merged
merged 22 commits into from Nov 19, 2019
Merged

Internationalization/Localization support #236

merged 22 commits into from Nov 19, 2019

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Nov 10, 2019

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Issue Number: #220

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Since Poetry does not have plugin support, I added a Makefile to do the job.

pyproject.toml Outdated
@@ -53,7 +53,7 @@ sphinx = "^2.2"
recommonmark = "^0.6.0"
sphinx-rtd-theme = "^0.4.3"
babel = "^2.7.0"
BabelGladeExtractor = "^0.5.1"
babelgladeextractor = { git = "https://github.com/gaphor/babel-glade.git", branch = "master" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like poetry (including 1.0.0b5) is currently broken when trying to install from a git repo, I think that is why you are getting the errors in Windows with CI.

no longer need my fork.
@amolenaar amolenaar merged commit 537a19e into master Nov 19, 2019
@danyeaw danyeaw deleted the i18n branch November 21, 2019 02:19
@danyeaw danyeaw mentioned this pull request Nov 21, 2019
3 tasks
@danyeaw danyeaw added the feature A new feature label Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants