New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internationalization/Localization support #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolenaar
force-pushed
the
i18n
branch
2 times, most recently
from
November 15, 2019 22:21
a1aaa41
to
8f08082
Compare
danyeaw
reviewed
Nov 17, 2019
pyproject.toml
Outdated
@@ -53,7 +53,7 @@ sphinx = "^2.2" | |||
recommonmark = "^0.6.0" | |||
sphinx-rtd-theme = "^0.4.3" | |||
babel = "^2.7.0" | |||
BabelGladeExtractor = "^0.5.1" | |||
babelgladeextractor = { git = "https://github.com/gaphor/babel-glade.git", branch = "master" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like poetry (including 1.0.0b5) is currently broken when trying to install from a git repo, I think that is why you are getting the errors in Windows with CI.
This avoid unneeded rebuilds of i18n catalogs.
no longer need my fork.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #220
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Since Poetry does not have plugin support, I added a
Makefile
to do the job.