Toggle visibility of ProxyPort.type

[amolenaar]

PR Type

What kind of change does this PR introduce?

• Bug fix
• Feature
• Chore (refactoring, formatting, local variables, other cleanup)
• Documentation content changes

What is the current behavior?

Type of proxy ports is not shown

Issue Number: Fixes #2424

What is the new behavior?

ProxyPort type is now shown if the "show-type" property is set.

[sz332]

Hello, I checked out the feature and it works, but maybe we can make it even better.

Suggestions:

• Remove the aggregate dropdown because it has no meaning for a port in my opinion @danyeaw
• Instead of show type checkbox have a dropdown where user can select: Display name, Display type, Display name and type
• If a Type is selected in the dropdown then the the second dropdown should automatically set it's value to Display name and type

[amolenaar]

Remove the aggregate dropdown because it has no meaning for a port in my opinion @danyeaw

Fair point, it's inherited from Property, the base type of ports.

Instead of show type checkbox have a dropdown where user can select: Display name, Display type, Display name and type

Not sure about this. Now the behavior is consistent with the Show ... switches for classes and blocks.
In what situations do you only want to show the type and not the name?

Another question: do we also want to show/hide the type for Properties in SysML?
At the moment I coded it as a special thingy for ProxyPorts only.

[danyeaw]

This looks great! I agree that we don't want 3 options. If you don't want to name your port, then well don't name your port 😄

Just one comment, I think there should be a space before the colon when we separate names from types.