Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree view should not collapse when an element is deleted #2493

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

When you delete an element, the parent node in the model browser collapses (closes).

Issue Number: fixes #2488

What is the new behavior?

Tree view does not collapse the node when an element changes inside.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@amolenaar amolenaar requested a review from danyeaw July 15, 2023 20:16
@github-actions github-actions bot added the python Pull requests that update Python code label Jul 15, 2023
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amolenaar This looks great!

@danyeaw danyeaw added fix A fix for a bug and removed python Pull requests that update Python code labels Jul 16, 2023
@danyeaw danyeaw merged commit c5c0819 into main Jul 16, 2023
20 checks passed
@danyeaw danyeaw deleted the keep-model-browser-expanded branch July 16, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not close the tree when (last) element is removed
2 participants