Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format pins by their name #2494

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Format pins by their name #2494

merged 1 commit into from
Jul 17, 2023

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Jul 16, 2023

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

When the name of a pin is changed, the change is not reflected in the model browser.

A Pin is also a MultiplicityElement, and that's how it's formatted.

Issue Number: fixes #2487

What is the new behavior?

Pin name is shown in the model browser.

@amolenaar amolenaar marked this pull request as draft July 16, 2023 07:35
@github-actions github-actions bot added the python Pull requests that update Python code label Jul 16, 2023
Pin also inherits from MultiplicityElement, and that's how it was
formatted.
@amolenaar amolenaar changed the title Add test that asserts pin name is updated Format pins by their name Jul 16, 2023
@amolenaar amolenaar requested a review from danyeaw July 16, 2023 10:32
@amolenaar amolenaar marked this pull request as ready for review July 16, 2023 10:41
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolenaar!

@danyeaw danyeaw added fix A fix for a bug and removed python Pull requests that update Python code labels Jul 17, 2023
@danyeaw danyeaw merged commit b26fa16 into main Jul 17, 2023
20 checks passed
@danyeaw danyeaw deleted the pin-name branch July 17, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Renaming a pin is not visible in tree
2 participants