Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the Language setting to Diagram Language #2500

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

tfirchau
Copy link
Contributor

Rename the "Language" setting in the model properties to "Diagram Language" and update documentation.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

The setting "Language" in the model properties is a bit ambiguous.

Issue Number: #2461

What is the new behavior?

Setting renamed to "Diagram Language". Together with extended documentation this should hopefully make it a bit more clear to the users what influences the (natural) language presented by Gaphor in the UI and Diagrams.

Does this PR introduce a breaking change?

  • Yes
  • No

Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tfirchau, this is a nice update!

@danyeaw danyeaw merged commit edbe8ee into gaphor:main Jul 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants