Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced GtkCheckButton with GtkSwitch #2502

Merged
merged 2 commits into from
Jul 18, 2023
Merged

Replaced GtkCheckButton with GtkSwitch #2502

merged 2 commits into from
Jul 18, 2023

Conversation

sz332
Copy link
Contributor

@sz332 sz332 commented Jul 17, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Checkbox is displayed instead of a switch, making the UI inconsitent.

Issue Number: 2489

What is the new behavior?

Replaced checkbox with switch, making the UI consistent.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the python Pull requests that update Python code label Jul 17, 2023
@amolenaar
Copy link
Member

Looks good. Thank @sz332!

@all-contributors add @sz332 for code

@allcontributors
Copy link
Contributor

@amolenaar

@sz332 already contributed before to code

@amolenaar amolenaar merged commit 9e64674 into gaphor:main Jul 18, 2023
7 checks passed
@danyeaw danyeaw added fix A fix for a bug and removed python Pull requests that update Python code labels Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants