Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate build and test #2513

Merged
merged 4 commits into from
Jul 22, 2023
Merged

Separate build and test #2513

merged 4 commits into from
Jul 22, 2023

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Jul 18, 2023

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the new behavior?

  • Separated install and test steps - this makes it more clear to the tests.
  • Move coverage config to .coveragerc. It looks like pytest-cov is not picking up the config from pyproject.toml (many warnings on not-found source files).

...

We're currently testing with X11 only. It may be worthwhile to test with a Wayland backend as well.

@amolenaar amolenaar requested a review from danyeaw July 22, 2023 13:07
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring of the CI pipeline!

@danyeaw danyeaw added the chore Maintenance related PR label Jul 22, 2023
@danyeaw danyeaw merged commit cf8f1f6 into main Jul 22, 2023
20 checks passed
@danyeaw danyeaw deleted the separate-build-and-test branch July 22, 2023 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants