Direct association #2526
Merged
Direct association #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
|
@sz332 This looks good. Is it ready to merge? |
It is ready to merge, the one think I don't know how to do is translation. Should I do something, or is it a separate process? If I need to do something, can you please help me to add the necessary translation string? |
|
Translation is something we kick of separately mostly, so we can update all text in one shot. |
amolenaar
approved these changes
Jul 22, 2023
|
@sz332 The unit tests fail with a message: I think the keyboard shortcut should be removed from directed-association. It can be |
Removed the keyboard shortcuts. Can you try it out? Thanks! |
danyeaw
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
Direct association between classes and sysml blocks.
What is the current behavior?
Currently it is very painful to create a direct (navigable) association. A normal association must be created, then going into properties, finding the tail element, and setting navigability. It takes just too much time.
Issue Number: 2516
What is the new behavior?
A new toolbar button is added enabling the same outcome with a single click.
Does this PR introduce a breaking change?
Other information
I could not find how to properly do the translations so I need some help in that.