Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when inverting association #2527

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Fix error when inverting association #2527

merged 1 commit into from
Jul 22, 2023

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: Fixes #2506

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@amolenaar amolenaar requested review from danyeaw and sz332 July 22, 2023 13:41
@github-actions github-actions bot added the python Pull requests that update Python code label Jul 22, 2023
@sz332
Copy link
Contributor

sz332 commented Jul 22, 2023

Works fine!

sz332
sz332 approved these changes Jul 22, 2023
View reviewed changes
Copy link
Contributor

@sz332 sz332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected.

@amolenaar amolenaar merged commit c7c0c8a into main Jul 22, 2023
20 checks passed
@amolenaar amolenaar deleted the fix-association-invert-direction branch July 22, 2023 15:49
@danyeaw danyeaw added fix A fix for a bug and removed python Pull requests that update Python code labels Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sz332 sz332 sz332 approved these changes

@danyeaw danyeaw Awaiting requested review from danyeaw

Assignees
No one assigned
Labels
fix A fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inverting direction causes error
3 participants
@amolenaar @sz332 @danyeaw