Type selection for Lifelines #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a generic component used for different model elements.
amolenaar
force-pushed
the
type-for-lifeline
branch
from
2d24f9c
to
9850de4
Compare
Co-authored-by: Sourcery AI <>
danyeaw
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Hi @amolenaar, I reviewed these code changes and they look good. I'm on vacation for a few days and don't have the ability to give the feature a spin, but I'm good to merge it when you are ready. 👍
danyeaw
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Lifelines cannot have a type
Issue Number: #2514
What is the new behavior?
Be able to select a type (
ConnectableElement) and show it on the element.A lifeline represents a ConnectableElement, however, Classifiers are not connectable elements, except for Interface, Prpoerty and Parameter. Not sure how to assign a Block to a Lifeline.