Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin type multiplicity #2534

Merged
merged 9 commits into from
Jul 23, 2023
Merged

Pin type multiplicity #2534

merged 9 commits into from
Jul 23, 2023

Conversation

sz332
Copy link
Contributor

@sz332 sz332 commented Jul 23, 2023

Add ability to set the pin type and multiplicity.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Pin types and multiplicities cannot be set for a particular pin.

Issue Number: #2485

What is the new behavior?

When selecting a pin a properties panel is displayed where the type and multiplicity of the pin can be set. The modification is displayed on the diagram and in the tree as well.

Does this PR introduce a breaking change?

  • Yes
  • No

@sz332 sz332 requested a review from amolenaar July 23, 2023 05:40
@github-actions github-actions bot added the python Pull requests that update Python code label Jul 23, 2023
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sz332.

It works well. I like how you display the multiplicity field.

@amolenaar amolenaar merged commit 991729f into gaphor:main Jul 23, 2023
6 checks passed
@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code labels Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants