Avoid copy cycles when fully pasting diagram items #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danyeaw
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
@amolenaar This looks good, just one comment about a small cleanup
Makes for nicer copy/paste behavior.
amolenaar
force-pushed
the
fix-copy-paste
branch
from
4230dce
to
0c7e45d
Compare
danyeaw
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR on #2475
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2536, #2475
What is the new behavior?
Do not error if we copy complex structures.
Does this PR introduce a breaking change?
Other information