Proxy port and activity pin stay connected; activity parameter node is always stuck to the activity when moving #2542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… connection; ensure that activity parameter node is always stuck to the activity when moving.
marek-piirikivi
changed the title
The blockmove module indirectly import Gdk. That should only happen if a uit session is loaded.
Move blockmove initialization to uicomponents module
|
Works like a charm. Thanks @marek-piirikivi! |
amolenaar
changed the title
3 tasks
danyeaw
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added StickyAttachedHandleMove which can be registered to the items that once connected, can not be disconnected via dragging and can only be moved along the border.
I added this behavior to activity parameters (only dragging functionality; otherwise was already there inability to disconnect); pins (both input and output); proxyport.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2484, #2450 (only point 3 from the initially proposed solution)
What is the new behavior?
Does this PR introduce a breaking change?
Other information
From the both related issues, not having free floating port/pin at all is not yet addressed - it is still possible to have free floating port/pin if it has never been attached to anything, but at least it is not possible to detach it anymore other than explicitly deleting.