Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface block support on diagram #2578

Merged
merged 7 commits into from
Aug 5, 2023
Merged

Conversation

sz332
Copy link
Contributor

@sz332 sz332 commented Jul 29, 2023

Added the ability to create an interface block on diagram.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Cannot add interface block to a SysML diagram.

Issue Number: #2570

What is the new behavior?

Can add interface block to a SysML diagram.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the python Pull requests that update Python code label Jul 29, 2023
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great update to add Interface Block support @sz332! I had a couple of comments, and also I noticed that the icon is broken for me in the Model Browser.

@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code labels Aug 3, 2023
@github-actions github-actions bot added the python Pull requests that update Python code label Aug 3, 2023
@danyeaw danyeaw removed the python Pull requests that update Python code label Aug 5, 2023
@danyeaw danyeaw merged commit a2cb46d into gaphor:main Aug 5, 2023
20 checks passed
@danyeaw
Copy link
Member

danyeaw commented Aug 5, 2023

Thanks @sz332!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants