Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New element creation through model browser #2585

Merged

Conversation

marek-piirikivi
Copy link
Contributor

Allows creating new elements directly in the model browser.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: #2552

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the python Pull requests that update Python code label Jul 31, 2023
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think the limited submenu is indeed the way to go. One comment on naming, though.

gaphor/diagram/diagramtoolbox.py Outdated Show resolved Hide resolved
@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code labels Aug 5, 2023
@danyeaw
Copy link
Member

danyeaw commented Aug 5, 2023

I love this feature, nice one @marek-piirikivi 🤩
@amolenaar are you good to merge this one?

@amolenaar
Copy link
Member

Yup, works as expected.

We may want to extend it at some point (e.g. create actions in activities), but that can be done later.

@amolenaar amolenaar merged commit 39a6e56 into gaphor:main Aug 6, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants