Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ValueSpecificationAction #2601

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Add ValueSpecificationAction #2601

merged 2 commits into from
Aug 8, 2023

Conversation

marek-piirikivi
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the python Pull requests that update Python code label Aug 4, 2023
@marek-piirikivi
Copy link
Contributor Author

@sz332 Please review if this is what you desired and also whether it is conforming with standards - I think I got it right. But I failed to locate where this stereotype "valueSpecification" originates from because I could not find it from UML not that I started checking it, so it might be SysML exclusive thing, but I am not entirely sure.

@marek-piirikivi marek-piirikivi force-pushed the value_specification_action branch 2 times, most recently from 5c3f7cb to a18ec0a Compare August 5, 2023 04:19
@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code labels Aug 5, 2023
@sz332
Copy link
Contributor

sz332 commented Aug 5, 2023

I checked in the standard and various tools, and I think you got it right.

The <> is according to my understanding is not a stereotype but a visual aid for modelers to see that this action is actually a value specification action. I have seen this behaviour in some tools, but there are some that use just a label Value specification without the stereotype notation.

@sz332 sz332 requested a review from danyeaw August 5, 2023 19:30
@sz332
Copy link
Contributor

sz332 commented Aug 5, 2023

@danyeaw can you please review? From my point of view it is a good V1 feature, gets the job done for now.

amolenaar
amolenaar approved these changes Aug 6, 2023
View reviewed changes
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a valuable improvement 😉 .

@marek-piirikivi
Copy link
Contributor Author

Looks like a valuable improvement.

@amolenaar Ah, I finally see what you did there! 😂 Nice one!

@github-actions github-actions bot added the python Pull requests that update Python code label Aug 8, 2023
@danyeaw danyeaw removed the python Pull requests that update Python code label Aug 8, 2023
danyeaw
danyeaw approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marek-piirikivi!

@danyeaw danyeaw merged commit cb572c6 into gaphor:main Aug 8, 2023
20 checks passed
@danyeaw danyeaw mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sz332 sz332 sz332 left review comments

@amolenaar amolenaar amolenaar approved these changes

@danyeaw danyeaw danyeaw approved these changes

Assignees
No one assigned
Labels
feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marek-piirikivi @sz332 @amolenaar @danyeaw