Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix derive-reqt modelbrowser icon #2626

Merged

Conversation

marek-piirikivi
Copy link
Contributor

  • Changed icon id in stencil.svg derive → derive-reqt
  • Ran makefile to re-generate icons from the stencil
  • Made necessary changes in hardcoded icon paths in requirementstoolbox

The bug most probably originated by a previous makefile run removing derive-reqt icon because it was not in the stencil.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: #2622

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the python Pull requests that update Python code label Aug 10, 2023
* Changed icon id in stencil.svg derive → derive-reqt
* Ran makefile to re-generate icons from the stencil
* Made necessary changes in hardcoded icon paths in requirementstoolbox

The bug most probably originated by a previous makefile run removing derive-reqt icon
because it was not in the stencil.
@marek-piirikivi marek-piirikivi force-pushed the fix_missing_derive_relationship_icon branch from 1f5a750 to 41a921c Compare August 10, 2023 03:54
@amolenaar amolenaar merged commit 116e4ca into gaphor:main Aug 10, 2023
20 checks passed
@amolenaar
Copy link
Member

Looks good!

@danyeaw danyeaw added fix A fix for a bug and removed python Pull requests that update Python code documentation labels Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A fix for a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants