Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage reporting #2635

Merged
merged 2 commits into from
Aug 12, 2023
Merged

Improve coverage reporting #2635

merged 2 commits into from
Aug 12, 2023

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Aug 11, 2023

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the new behavior?

Ignore parts that are never executed, such as protocols, overloaded and abstract methods.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Make use of tuples in for ... in (...) statements consistent.

@amolenaar amolenaar marked this pull request as draft August 11, 2023 13:52
@github-actions github-actions bot added the python Pull requests that update Python code label Aug 11, 2023
Ignore parts that are never executed, such as protocols, overloaded and
abstract methods.
This makes the code slightly more consistent.
@amolenaar amolenaar requested a review from danyeaw August 11, 2023 15:44
@amolenaar amolenaar marked this pull request as ready for review August 11, 2023 15:50
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@danyeaw danyeaw added chore Maintenance related PR and removed python Pull requests that update Python code labels Aug 12, 2023
@danyeaw danyeaw merged commit 4a727cf into main Aug 12, 2023
33 checks passed
@danyeaw danyeaw deleted the coverage-reporting branch August 12, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants