Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests and fix Component.required #2652

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Add tests and fix Component.required #2652

merged 1 commit into from
Aug 18, 2023

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Issue Number: #2650

What is the new behavior?

Fixed Component.required property.

@amolenaar amolenaar linked an issue Aug 17, 2023 that may be closed by this pull request
Interface object is not subscriptable #2650
Closed
3 tasks
@amolenaar amolenaar requested a review from danyeaw August 17, 2023 19:13
@github-actions github-actions bot added the python Pull requests that update Python code label Aug 17, 2023
@danyeaw danyeaw added fix A fix for a bug and removed python Pull requests that update Python code labels Aug 18, 2023
@danyeaw danyeaw merged commit 417df59 into main Aug 18, 2023
33 checks passed
@danyeaw danyeaw deleted the fix-component-provided branch August 18, 2023 16:34
@danyeaw
Copy link
Member

danyeaw commented Aug 18, 2023

Thanks @amolenaar!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyeaw danyeaw Awaiting requested review from danyeaw

Assignees
No one assigned
Labels
fix A fix for a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interface object is not subscriptable
2 participants
@amolenaar @danyeaw