Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support state entry, exit, do behavior selection amongst the existing behaviors via dropdown #2665

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

marek-piirikivi
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

Adds drop-down selection to select entry, exit, do behaviors amongst the existing behaviors.

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Currently, a textfield is used to define entry, exit, do behaviors which always create new activities. It is not possible to select existing activities.

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Ideally, I would like to preserve the option to create the behavior when it does not exist on the property page; or defer its creation at the later point and just keep it as a text.

@github-actions github-actions bot added python Pull requests that update Python code documentation labels Aug 21, 2023
@marek-piirikivi marek-piirikivi self-assigned this Aug 23, 2023
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works really nice! Thanks @marek-piirikivi

@amolenaar amolenaar merged commit 33ad92c into gaphor:main Sep 1, 2023
20 checks passed
@danyeaw danyeaw added feature A new feature and removed python Pull requests that update Python code documentation labels Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants