Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Console again, workaround for CI #268

Merged
merged 1 commit into from Feb 17, 2020
Merged

Enable Console again, workaround for CI #268

merged 1 commit into from Feb 17, 2020

Conversation

amolenaar
Copy link
Member

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Workaround for #245.

What is the new behavior?

Tests work, with console window enabled.

Does this PR introduce a breaking change?

  • Yes
  • No

@amolenaar amolenaar changed the title Add Console, but removed completer import from console.py Enable Console again, workaround for CI Feb 16, 2020
@danyeaw danyeaw merged commit b20cfc0 into master Feb 17, 2020
@danyeaw danyeaw deleted the console-workaround-for-ci branch February 17, 2020 02:14
@danyeaw danyeaw added the chore Maintenance related PR label Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Maintenance related PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amolenaar @danyeaw