Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installer fixes #269

Merged
merged 17 commits into from Feb 26, 2020
Merged

Windows installer fixes #269

merged 17 commits into from Feb 26, 2020

Conversation

amolenaar
Copy link
Member

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Gaphor installed on windows does not start.

What is the new behavior?

Well, it should start.

@amolenaar amolenaar added the chore Maintenance related PR label Feb 17, 2020
@amolenaar amolenaar added this to the 1.2.0 milestone Feb 17, 2020
@danyeaw
Copy link
Member

danyeaw commented Feb 23, 2020

@amolenaar This should be good to go. The installer is working successfully for me. My suggestion is we merge this, but keep your manual installer branch if we find PyInstaller to be too fragile at a later date.

@amolenaar
Copy link
Member Author

Yes! It works with me :).

@amolenaar amolenaar merged commit db9cf77 into master Feb 26, 2020
@danyeaw danyeaw deleted the win-installer branch March 1, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants