Use defusedxml to avoid loading potentially dangerous xml #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolenaar
force-pushed
the
saver-xml
branch
from
67c27f1
to
c4a0e13
Compare
amolenaar
force-pushed
the
saver-xml
branch
from
c4a0e13
to
df6b62a
Compare
for more information, see https://pre-commit.ci
danyeaw
added
chore
|
Hey @amolenaar good idea to think about this. Would the attack vector that someone shares a malicious Gaphor model with others? |
|
Yes, that can be a possibility. I hooked up Gaphor with Snyk and it exposed this as a weakness. Snyk also suggested to use defusedxml. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Gaphor should be less vulnerable to maliciously crafted XML.
Does this PR introduce a breaking change?
Other information
See https://cwe.mitre.org/data/definitions/611.html.