Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectilinear lines #272

Merged
merged 2 commits into from Feb 22, 2020
Merged

Rectilinear lines #272

merged 2 commits into from Feb 22, 2020

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Naming of the options around rectilinear lines is unclear.

Issue Number: #186

What is the new behavior?

use more clear terminology.

Does this PR introduce a breaking change?

  • Yes
  • No

Make "flip orientation" option only selectable when using a rectilinear
line.
@amolenaar amolenaar added the bug An issue in the application label Feb 21, 2020
@amolenaar amolenaar added this to the 1.2.0 milestone Feb 21, 2020
@danyeaw danyeaw merged commit 23cf59c into master Feb 22, 2020
@danyeaw
Copy link
Member

danyeaw commented Feb 22, 2020

I like the updated words!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue in the application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants