Sequence diagram updates #273
Conversation
So class related info is properly shown again.
Get the basic styling in place for fill and later stroke color.
Can place it on canvas, no interaction with model yet.
Get rid of ConnectBase and AbstractConnect.
So Gaphor can have it's own Connector.
A much more lively name. Despite it being used in the model and Gaphas.
amolenaar
force-pushed
the
interaction-updates
branch
from
ab538f5
to
5fcdb88
Compare
Still need to move ports in the right place.
Add ConnectorProtocol and fix a bunch of typing errors
This saves a lot of checks in the code.
amolenaar
force-pushed
the
interaction-updates
branch
from
5465316
to
ae8e06a
Compare
Loading seems flaky still. items do not show on their appropriate place.
There was a problem hiding this comment.
I reviewed this PR at this point. Wow @amolenaar, really nice job with these enhancements!
|
I'm not happy with the current state of the PR. In order to create an Execution Specification, one has ro connect a handle on the ExecSpec item. This will also make the ExecSpec a child item of the Lifeline or ExecSpec. This seems like a bit too much. For one, I find it weird to be able to connect one handle (the other handle is not connectable). It should just "drop" on the lifeline. However, the current grouping code does not align child elements in a particular way. There's still some work to do. |
Matrices should be updated properly.
|
I'll keep it as is for now: a handle on the exec spec should connect to the lifeline. |
`Lifeline.coveredBy`
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #143
What is the new behavior?
Churn:
IConnectinterface toConnector.NB. detach ExecSpec with Messages or other ExecSpecs attached!
Does this PR introduce a breaking change?
Other information
[1] If Gaphor orders the OccurrenceSpecifications in accordance to the diagram, one can actually do something with such a diagram, e.g. generate a test script that validates the messages with the real application.