Move element editor layouts to Glade #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no longer used
Instead, let the property pages handle this.
Needs to be implemented still.
So not clean model anymore.
amolenaar
force-pushed
the
ui-with-glade
branch
from
8c42667
to
93301d9
Compare
Fixed some padding inconsistencies in the glade file.
Saves confusion with insensitive toggle.
Clean up unused code
Looking for the reason of the missing last row.
amolenaar
force-pushed
the
ui-with-glade
branch
from
3128131
to
b6c4f9e
Compare
based on changed made elsewhere in the application.
amolenaar
changed the title
|
@danyeaw I think the element editor looks better now. Also, some small issues I ran into have been fixed. |
|
@amolenaar very cool, I think this helps separate the GUI from the other code and logic 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
All GTK+ layout is hard-coded in Python.
What is the new behavior?
Layouts are loaded from
Gtk.Builder(Glade) files.This has the advantage that it's easier to visibly change the layout of a component. This will lead to less code, and can result in a more snappy UI.
Does this PR introduce a breaking change?