Comment line fixes #280
Merged
Comment line fixes #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolenaar
force-pushed
the
comment-line-fixes
branch
2 times, most recently
from
bfa23e3
to
d74aba8
Compare
danyeaw
reviewed
Mar 29, 2020
| from gaphor.diagram.classes import ClassItem, GeneralizationItem | ||
| from gaphor.diagram.general import CommentItem, CommentLineItem | ||
| from gaphor.diagram.tests.fixtures import connect | ||
| from gaphor.services.sanitizerservice import SanitizerService | ||
| from gaphor.tests import TestCase |
There was a problem hiding this comment.
I think we can remove the TestCase import here.
| from gaphor import UML | ||
| from gaphor.diagram.classes.generalization import GeneralizationItem | ||
| from gaphor.diagram.classes.klass import ClassItem | ||
| from gaphor.diagram.general.comment import CommentItem | ||
| from gaphor.diagram.general.commentline import CommentLineItem | ||
| from gaphor.diagram.tests.fixtures import allow, connect, disconnect | ||
| from gaphor.diagram.usecases.actor import ActorItem | ||
| from gaphor.tests import TestCase |
amolenaar
force-pushed
the
comment-line-fixes
branch
from
d74aba8
to
1de4839
Compare
7 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
See #72
Issue Number: N/A
What is the new behavior?
A background service (sanitizer) ensures elements have their comments attached.
Does this PR introduce a breaking change?