Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade notarization from altool to notarytool #2806

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Oct 28, 2023

Fixes #2781.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

altool is used for notarization using GitHub Actions

Issue Number: N/A

What is the new behavior?

Use notarytool and stapler directly.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@danyeaw danyeaw added the chore Maintenance related PR label Oct 28, 2023
@danyeaw
Copy link
Member Author

danyeaw commented Oct 28, 2023

@amolenaar I overrode the mainline build flag for testing this, and it passed all tests 👍

Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@amolenaar amolenaar merged commit 8a20152 into main Nov 1, 2023
32 checks passed
@amolenaar amolenaar deleted the notarytool branch November 1, 2023 08:05
@amolenaar
Copy link
Member

Checked it on macOS: Image build on the main branch works fine.

image

Output from codesign also looks okay:

$ codesign -dv /Volumes/Gaphor\ 2.21.0.dev4109+70167238/Gaphor.app
Executable=/Volumes/Gaphor 2.21.0.dev4109+70167238/Gaphor.app/Contents/MacOS/gaphor
Identifier=org.gaphor.gaphor
Format=app bundle with Mach-O thin (x86_64)
CodeDirectory v=20500 size=63133 flags=0x10000(runtime) hashes=1962+7 location=embedded
Signature size=8973
Timestamp=4 Nov 2023 at 09:41:39
Info.plist entries=21
TeamIdentifier=Z7V37BLNR9
Runtime Version=11.3.0
Sealed Resources version=2 rules=13 files=4598
Internal requirements count=1 size=180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to notarytool for macOS
2 participants