Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Update portable shell link shortcut #2851

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Windows: Update portable shell link shortcut #2851

merged 1 commit into from
Nov 23, 2023

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Nov 18, 2023

When we updated to PyInstaller 6.x, it broke the portable app shortcut. This PR updates the shortcut to point to the right relative path.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Windows portable download had a broken shortcut

Issue Number: N/A

What is the new behavior?

Shortcut is fixed

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the packaging Update to packaging aspects label Nov 18, 2023
@danyeaw danyeaw added chore Maintenance related PR and removed packaging Update to packaging aspects labels Nov 19, 2023
@danyeaw danyeaw marked this pull request as draft November 19, 2023 03:30
@danyeaw danyeaw marked this pull request as ready for review November 20, 2023 22:31
@github-actions github-actions bot added the packaging Update to packaging aspects label Nov 20, 2023
amolenaar
amolenaar approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really test this, but I suppose it'll work.

@danyeaw danyeaw merged commit 0f0e4d7 into main Nov 23, 2023
32 checks passed
@danyeaw danyeaw deleted the update-lnk branch November 23, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amolenaar amolenaar amolenaar approved these changes

@marek-piirikivi marek-piirikivi Awaiting requested review from marek-piirikivi

Assignees
No one assigned
Labels
chore Maintenance related PR packaging Update to packaging aspects
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danyeaw @amolenaar