Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyInstaller Spec File Updates #2857

Merged
merged 3 commits into from
Nov 23, 2023
Merged

PyInstaller Spec File Updates #2857

merged 3 commits into from
Nov 23, 2023

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Nov 20, 2023

Small updates to the spec file:

  1. Fix PEP 597 encoding error
  2. Remove an unused import
  3. Remove a version check, since all builds of Gaphor should be with Python 3.11+.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Encoding warnings during CI/CD pipeline runs

Issue Number: N/A

What is the new behavior?

Fewer warnings

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the packaging Update to packaging aspects label Nov 20, 2023
@danyeaw danyeaw added chore Maintenance related PR and removed packaging Update to packaging aspects labels Nov 21, 2023
amolenaar
amolenaar approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danyeaw danyeaw merged commit 50cc896 into main Nov 23, 2023
32 checks passed
@danyeaw danyeaw deleted the encoding-warning branch November 23, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amolenaar amolenaar amolenaar approved these changes

@marek-piirikivi marek-piirikivi Awaiting requested review from marek-piirikivi

Assignees
No one assigned
Labels
chore Maintenance related PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danyeaw @amolenaar