Settings cleanup #2879
Merged
Settings cleanup #2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it more explicit which settings can be set. Also make sure that the color scheme is enforced on startup, according to user preferences.
It's not only dark, but also light mode.
Update application color scheme based on the selected value.
danyeaw
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Hi @amolenaar, really nice refactoring! I'm always learning from you 🥇
danyeaw
added
chore
|
😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If a preferred color scheme is selected, it's not set when you (re)start the application.
Issue Number: N/A
What is the new behavior?
I made the Settings object a more rich object and moved many of the settings there. This makes the interface we have to use easier (no optional
Noneobject).Changed the message that settings cannot be loaded to warning, so it's shown before the logging module is configured.
The application color scheme is updated according to the setting in a reactive fashion.
Does this PR introduce a breaking change?
Other information