Make ActivityParameterNode droppable #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
python
amolenaar
approved these changes
Dec 2, 2023
|
Converted to draft because I'll add tests. |
marek-piirikivi
force-pushed
the
activity_parameter_node_drop
branch
from
615a916
to
5263f2f
Compare
for more information, see https://pre-commit.ci
|
@amolenaar It's ready now. I added tests. Please review 🙏 It looks nearly identical to what I did with proxy ports. I believe it is possible to make this behavior generic for all droppable and attachable items. Seems the kind of behavior that we would like every droppable attachable to have (relationship lines included) - but that's just some thoughts for future. |
|
Looks good. Thanks @marek-piirikivi. I think the build error is something that was fixed on main already, so I'll just merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes ActivityParameterNode droppable.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently activity parameter node items can only be attached on the activity item by adding new nodes from the property menu. However, you can freely delete the items - and sometimes you want to do that to keep the diagram cleaner - you can not add them pack if you have mistakenly done so.
Issue Number: N/A
What is the new behavior?
Activity parameter node items can now additionally attached to the activity items by dropping the activity's parameters from the model browser.
Does this PR introduce a breaking change?
Other information