Format files accessed from Flatpak via portals #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolenaar
force-pushed
the
file-portal
branch
from
b293871
to
de9ae93
Compare
amolenaar
force-pushed
the
file-portal
branch
from
de9ae93
to
5828f60
Compare
Try to hide the (ugly) mount folder name if flatpak is run without filesystem permissions.
amolenaar
force-pushed
the
file-portal
branch
from
5828f60
to
44085cc
Compare
danyeaw
added
feature
danyeaw
approved these changes
Dec 4, 2023
|
The text is sort of similar to what you see in Text Editor, once you revoked filesystem access through Flatseal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
On Flathub, Gaphor has a big "Potential risk" thingy. This is due to the requested file system access. Strictly speaking we do not need this permission, since we can open files via Portals.
Issue Number: flathub/org.gaphor.Gaphor#91
What is the new behavior?
Filenames of files accessed through Portals are shown with the file name only.
I added a remark at the end "(Flatpak Document Portal)", but I'm not sure if that's needed or even a good idea. Do average users care about Portals?
Does this PR introduce a breaking change?
Other information
If we agree this is a good idea, we can drop the filesystem permissions for the next release.