Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update macOS icon #2911

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Update macOS icon #2911

merged 1 commit into from
Dec 7, 2023

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Dec 7, 2023

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

The current macOS icon is the same as we use on linux and windows. It looks a bit out of order though: pretty much all icons on macOS have a background with rounded corners.

Issue Number: N/A

What is the new behavior?

A background on the icon:

image

I'm not 100% sure about the placement of the logo on the background.

@github-actions github-actions bot added the packaging Update to packaging aspects label Dec 7, 2023
@danyeaw danyeaw added the chore Maintenance related PR label Dec 7, 2023
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@danyeaw danyeaw merged commit 8a61a27 into main Dec 7, 2023
20 checks passed
@danyeaw danyeaw deleted the macos-logo branch December 7, 2023 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR packaging Update to packaging aspects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants