Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Profile Selection Combo Box for SysML #293

Merged
merged 10 commits into from Apr 6, 2020
Merged

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Apr 5, 2020

This PR adds a drop down combo box to select a new profile.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Issue Number: #138

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
@danyeaw danyeaw requested a review from amolenaar April 5, 2020 19:03
@github-actions github-actions bot added the feature A new feature label Apr 5, 2020
Copy link
Member

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice bit of cleanup! Apart from 2 minor things, i think this can go right into master.

gaphor/diagram/connectors.py Outdated Show resolved Hide resolved
gaphor/ui/toolbox.py Show resolved Hide resolved
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
Signed-off-by: Dan Yeaw <dan@yeaw.me>
@danyeaw danyeaw merged commit 6cbdfba into master Apr 6, 2020
@danyeaw danyeaw deleted the feature/profile-combobox branch April 6, 2020 01:20
@danyeaw danyeaw mentioned this pull request Apr 17, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants