Move core modelling concepts to a separate package #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolenaar
force-pushed
the
separate-model-core
branch
from
a5c5f11
to
f4591d7
Compare
amolenaar
force-pushed
the
separate-model-core
branch
from
a2a279f
to
b6cbf2b
Compare
amolenaar
force-pushed
the
separate-model-core
branch
from
ec18578
to
f2978df
Compare
amolenaar
changed the title
|
I think this is done, at least for the model. |
danyeaw
reviewed
Apr 10, 2020
danyeaw
reviewed
Apr 10, 2020
danyeaw
reviewed
Apr 10, 2020
danyeaw
approved these changes
Apr 10, 2020
No need to refer to UML in diagram module.
|
@amolenaar Windows builds are failing. I submitted an issue to help try to resolve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Part of #138.
What is the current behavior?
Evenrything is in
gaphor.UML, which makes for no logical separation when extending Gaphor with other modelling types.What is the new behavior?
ElementPresentationElementFactoryDiagram(it's aNamedElement)Does this PR introduce a breaking change?