Less padding around windows on macOS #2952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolenaar
changed the title
danyeaw
approved these changes
Dec 23, 2023
danyeaw
added
chore
|
I just did a check on Windows, and it suffers from the same problem. I think we can apply the same styling patch there as well. (click outside the window and see how far the mouse pointer has to be away from the real window before you can actually select a parent window). |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The Adwaita theme draws a wide shadow around the window. This shadow is part of the view on macOS.
You can see this easily when you open a file. The parent window is overlayed with a "sheet":
What is the new behavior?
The shadow has been tweaked to look more like a macOS shadow, and the shadow size is smaller. This improves the usability: the big (invisible) border is gone, so if you click on an underlying window, it will actually work.
Also the shadow looks a bit more mac-like:
Other information
GTK issue: https://gitlab.gnome.org/GNOME/gtk/-/issues/6255