Convert Stereotype property editors to ListView #2956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolenaar
force-pushed
the
stereotype-listview
branch
from
22d0725
to
cd8bb96
Compare
That can display a placeholder or nothing.
The containing box should be removed completely.
This is more in line with how other widgets react.
3 tasks
Seems more appropriate than "Attributes".
danyeaw
added
chore
danyeaw
approved these changes
Dec 30, 2023
| row[:] = row_data | ||
| return new_row | ||
| for st in sorted( | ||
| stereotypes, key=lambda s: normalize("NFC", s.name or "").casefold() |
There was a problem hiding this comment.
TIL about unicode normalize and casefold 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2231 , #2155
What is the new behavior?
Stereotype property page is using
Gtk.ColumnView, the modern alternative toGtk.TreeView.The stereotype view is somewhat simplified (no expander buttons). I expect this will work, as long as there are not too many stereotypes applicable for an element. Values for unapplied stereotypes are insensitive.
Does this PR introduce a breaking change?
Other information
ColumnViewproperty editors to start editing on theactivatesignal (double-click or Enter).