Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MSYS2 Package Names #296

Merged
merged 1 commit into from Apr 11, 2020
Merged

Fix MSYS2 Package Names #296

merged 1 commit into from Apr 11, 2020

Conversation

danyeaw
Copy link
Member

@danyeaw danyeaw commented Apr 10, 2020

MSYS2 made Python 3 the default, so package names no longer need to specify python3.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@danyeaw danyeaw added the chore Maintenance related PR label Apr 10, 2020
@danyeaw danyeaw requested a review from amolenaar April 11, 2020 02:25
@danyeaw danyeaw added this to the 1.3 milestone Apr 11, 2020
@danyeaw danyeaw merged commit 62b8aa7 into master Apr 11, 2020
@danyeaw danyeaw deleted the fix-window-package-names branch April 11, 2020 18:40
@danyeaw danyeaw modified the milestones: 1.3, 2.0 Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amolenaar amolenaar Awaiting requested review from amolenaar

Assignees
No one assigned
Labels
chore Maintenance related PR
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@danyeaw