Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Gaphas 4.0 #2960

Merged
merged 2 commits into from
Dec 30, 2023
Merged

Update to Gaphas 4.0 #2960

merged 2 commits into from
Dec 30, 2023

Conversation

amolenaar
Copy link
Member

@amolenaar amolenaar commented Dec 27, 2023 •
edited

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the new behavior?

No changes, just support Gaphas 4.0: gaphor/gaphas#741.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Before merging:

  • a new release of Gaphas is needed
  • a dependency update.
  • Remove temporary gaphas-4 branch installation

@amolenaar amolenaar marked this pull request as draft December 27, 2023 16:01
@github-actions github-actions bot added the python Pull requests that update Python code label Dec 27, 2023
@amolenaar amolenaar force-pushed the gaphas-4 branch 2 times, most recently from 9b416fa to a6f9cf2 Compare December 27, 2023 17:09
@amolenaar amolenaar marked this pull request as ready for review December 30, 2023 09:19
danyeaw
danyeaw approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done! It is great not having to pass the GtkView around 👍

@danyeaw danyeaw merged commit 684f7f5 into main Dec 30, 2023
20 checks passed
@danyeaw danyeaw deleted the gaphas-4 branch December 30, 2023 14:37
@danyeaw danyeaw added chore Maintenance related PR and removed python Pull requests that update Python code labels Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danyeaw danyeaw danyeaw approved these changes

Assignees
No one assigned
Labels
chore Maintenance related PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amolenaar @danyeaw