Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Ruff to (almost) all files #2979

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Apply Ruff to (almost) all files #2979

merged 3 commits into from
Jan 4, 2024

Conversation

amolenaar
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bug fix
  • Feature
  • Chore (refactoring, formatting, local variables, other cleanup)
  • Documentation content changes

What is the current behavior?

Currently, some files (__init__.py, diagramitems.py) are not linted and formatted. This can lead to undetected issues.

Issue Number: N/A

What is the new behavior?

Lint all python files, except generated files.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This may cause rework with currently outstanding PR's.

@amolenaar amolenaar requested a review from danyeaw January 4, 2024 15:04
@github-actions github-actions bot added the python Pull requests that update Python code label Jan 4, 2024
Copy link
Member

@danyeaw danyeaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amolenaar!

@danyeaw danyeaw added chore Maintenance related PR and removed python Pull requests that update Python code labels Jan 4, 2024
@danyeaw danyeaw merged commit 5d5ef5b into main Jan 4, 2024
20 checks passed
@danyeaw danyeaw deleted the lint-init branch January 4, 2024 19:48
@amolenaar amolenaar mentioned this pull request Jan 4, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants