Place UML model and diagram items closer together #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolenaar
changed the title
amolenaar
changed the title
Hotfix gaphor.core.modeling.elementdispatcher, since it has an explicit dependency on the UML model. Should be moved out into a ModelProvider service of some sort.
|
Part of #138 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The code is all around the UML model
What is the new behavior?
There is a distinction between the generic Gaphor functionality and the UML model. This should provide a first example of how to implement models as part of Gaphor.
Does this PR introduce a breaking change?
Notes:
Moved
Commentmodel element to the Core module. This reduces the dependency on UML model from the diagram model to one instance: meta-classes in property pages.